This repository was archived by the owner on Jun 3, 2024. It is now read-only.
God class codegen redux (now with an additional hack!) #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something something we can vote on if we want to use the hack or not? 👍 for 'LGTM' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#202 but it's a rewrite using javapoet and a hack to run an annotation processor on multiple projects at once:
https://github.com/kitlith/patchwork-api/blob/b91a4ebe7a2099fdbde457d953643d428249269e/patchwork-god-classes/build.gradle#L37-L68
I like this much better than #202, but I'm not sure how I feel about the hack involved. Given the usage of javapoet and how well it integrates with annotation processors, I feel a lot better about this version probably not breaking at some point, and being easier to extend/fix.
I'm leaving #202 open for now in the case that we want codegen, but don't want to use the hack in here.
... it appears that you can serialize individual methods and fields w/ javapoet, so if we don't like the hack, I can generate fragments of code which I then piece together later, and I can even reuse most of the code I wrote for this version. yay javapoet.
First 3 commits are from #201, please go there if you have concerns about how that's laid out.